Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-proxy config burst use int #57652

Closed
wants to merge 2 commits into from

Conversation

hzxuzhonghu
Copy link
Member

What this PR does / why we need it:

fix todo, ClientConnectionConfiguration.Burst use type int instead of int32 to prevent extra type cast.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hzxuzhonghu
We suggest the following additional approver: thockin

Assign the PR to them by writing /assign @thockin in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member Author

/assign @thockin

@xiangpengzhao
Copy link
Contributor

FYI: #53850. Seems like int32 is expected.

/cc @dougm @thockin

@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: GitHub didn't allow me to request PR reviews from the following users: dougm.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

FYI: #53850. Seems like int32 is expected.

/cc @dougm @thockin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu
Copy link
Member Author

@xiangpengzhao Thanks, I see.

@hzxuzhonghu hzxuzhonghu deleted the fix-todo branch December 28, 2017 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants