Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marking CSIPersistentVolumeSource as Beta #59157

Merged
merged 2 commits into from Feb 22, 2018
Merged

Marking CSIPersistentVolumeSource as Beta #59157

merged 2 commits into from Feb 22, 2018

Conversation

vladimirvivien
Copy link
Member

@vladimirvivien vladimirvivien commented Jan 31, 2018 •
edited by thockin

What this PR does / why we need it:
This PR marks the CSIPersistentVolumeSource type as being Beta

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #58718

Move CSI PersistentVolumes to Beta

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2018
@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 31, 2018
@vladimirvivien
Copy link
Member Author

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jan 31, 2018
@vladimirvivien
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2018
@vladimirvivien
Copy link
Member Author

/assign @vladimirvivien

@timothysc timothysc removed their request for review January 31, 2018 23:56
jsafrane
jsafrane reviewed Feb 2, 2018
View reviewed changes
pkg/apis/core/types.go
@@ -1600,7 +1600,7 @@ type LocalVolumeSource struct {
Path string
}

// Represents storage that is managed by an external CSI volume driver
// Represents storage that is managed by an external CSI volume driver (Beta feature)
type CSIPersistentVolumeSource struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a plan to add Attributes into CSIPersistentVolumeSource so we don't need to use annotations? I'd appreciate if the type was completed before marked as beta

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane yes there is a separate PR for it, this can stall until it goes in. #58762

@saad-ali
Copy link
Member

saad-ali commented Feb 7, 2018

/lgtm
/approve

I don't have a strong preference on merging this before or after #58762

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2018
@vladimirvivien
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@vladimirvivien: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vladimirvivien
Copy link
Member Author

@saad-ali please LGTM

@saad-ali
Copy link
Member

saad-ali commented Feb 15, 2018 •
edited

/lgtm
/approve

For API approval:
/assign @thockin

@k8s-ci-robot
Copy link
Contributor

@saad-ali: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/lgtm
/approve

For API approval:
/assign @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2018
@saad-ali
Copy link
Member

For API Approval:
/assign @thockin

@saad-ali
Copy link
Member

/test pull-kubernetes-verify

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 21, 2018
@thockin thockin removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 21, 2018
@thockin
Copy link
Member

thockin commented Feb 21, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, thockin, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 22, 2018 •
edited

@vladimirvivien: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws b5deaf6 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-verify b5deaf6 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 59052, 59157, 59428, 59949, 60151). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 2815ca4 into kubernetes:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@pmorie pmorie Awaiting requested review from pmorie

Assignees

@vladimirvivien vladimirvivien

@thockin thockin

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSI - Mark CSIPersistentVolumeSource type as Beta
6 participants
@vladimirvivien @saad-ali @k8s-ci-robot @thockin @k8s-github-robot @jsafrane