Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental keystone authenticator #59492

Merged

Conversation

dims
Copy link
Member

@dims dims commented Feb 7, 2018

What this PR does / why we need it:

experimental-keystone-url and experimental-keystone-ca-file were always
experimental. So we don't need a deprecation period.
KeystoneAuthenticator was on the server side and needed userid/password
to be passed in and used that to authenticate with Keystone. We now
have authentication and authorization web hooks that can be used. There
is a external repo with a webook for keystone which works fine along
with the kubectl auth provider that was added in:
a0cebcb

So we don't need this older style / hard coded / experimental code
anymore.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

kube-apiserver: the experimental in-tree Keystone password authenticator has been removed in favor of extensions that enable use of Keystone tokens.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2018
@dims
Copy link
Member Author

dims commented Feb 7, 2018

@dims
Copy link
Member Author

dims commented Feb 7, 2018

/sig openstack

@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Feb 7, 2018
@dims
Copy link
Member Author

dims commented Feb 7, 2018

/assign @FengyunPan
/assign @anguslees
/assign @NickrenREN

@hogepodge
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@dims dims force-pushed the remove-old-keystone-authenticator branch from 09adfee to 49784d2 Compare February 7, 2018 20:37
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@timothysc timothysc removed their request for review February 8, 2018 00:09
experimental-keystone-url and experimental-keystone-ca-file were always
experimental. So we don't need a deprecation period.
KeystoneAuthenticator was on the server side and needed userid/password
to be passed in and used that to authenticate with Keystone. We now
have authentication and authorization web hooks that can be used. There
is a external repo with a webook for keystone which works fine along
with the kubectl auth provider that was added in:
a0cebcb

So we don't need this older style / hard coded / experimental code
anymore.
@dims dims force-pushed the remove-old-keystone-authenticator branch from 49784d2 to 1859037 Compare February 8, 2018 00:29
@FengyunPan2
Copy link
Contributor

/test pull-kubernetes-unit

@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2018

/assign @tallclair @liggitt @ericchiang

@liggitt
Copy link
Member

liggitt commented Feb 8, 2018

cc @kubernetes/sig-auth-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 8, 2018
@liggitt
Copy link
Member

liggitt commented Feb 8, 2018

I'm in favor of removing this and pointing people to the openstack kubectl auth provider and webhook authenticators.

That said, it looks like #39587 was not documented properly. @dims, can you open a documentation pull request against https://kubernetes.io/docs/admin/authentication/ removing the keystone password section, and adding a subsection under "Webhook Token Authentication" that details configuration of kubectl with the openstack auth provider?

@liggitt liggitt added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 8, 2018
@dims
Copy link
Member Author

dims commented Feb 8, 2018

@liggitt i opened a WIP PR so i remember to do this - kubernetes/website#7304

@dims
Copy link
Member Author

dims commented Feb 8, 2018

@liggitt i'll be moving the personal repo into a git repo in the OpenStack foundation, so there's a pre-req before i wrap up the documentation PR. so it has the right info

@liggitt
Copy link
Member

liggitt commented Feb 8, 2018

i'll be moving the personal repo into a git repo in the OpenStack foundation, so there's a pre-req before i wrap up the documentation PR. so it has the right info

the kubectl side should be documented now.

your webhook authenticator is one possible option for turning keystone tokens into userinfo, and could be referenced as an example, without being positioned as the one true keystone webhook token authenticator (even once it is in the openstack foundation, alternative user mappings could be achieved through alternate webhooks)

@dims
Copy link
Member Author

dims commented Feb 8, 2018

@liggitt got it!

@ericchiang
Copy link
Contributor

Is this targeted for 1.10?

@liggitt
Copy link
Member

liggitt commented Feb 13, 2018

cc @kubernetes/sig-openstack-pr-reviews

Copy link
Member

@anguslees anguslees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good to see this gone...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2018
@liggitt
Copy link
Member

liggitt commented Feb 13, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anguslees, dims, hogepodge, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@dims
Copy link
Member Author

dims commented Feb 13, 2018

/test pull-kubernetes-bazel-test

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet