New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate repair-malformed-updates flag, move object meta mutation into BeforeCreate #61455

Merged

k8s-github-robot merged 1 commit into kubernetes:master from liggitt:uid-conflict

May 3, 2018

Member

liggitt commented Mar 21, 2018 •

edited

closes #23297

NONE

k8s-ci-robot added size/M cncf-cla: yes do-not-merge/release-note-label-needed approved labels

k8s-ci-robot requested review from krousey, mikedanese, ncdc and tallclair

March 21, 2018 05:21

liggitt force-pushed the uid-conflict branch from 6a2b1b8 to 7b5118f Compare

March 21, 2018 05:55

k8s-ci-robot added release-note-none and removed do-not-merge/release-note-label-needed labels

tallclair reviewed

View reviewed changes

staging/src/k8s.io/apimachinery/pkg/api/validation/objectmeta.go

    
              	}

              	if newMeta.GetDeletionTimestamp() != nil && (oldMeta.GetDeletionTimestamp() == nil || !newMeta.GetDeletionTimestamp().Equal(oldMeta.GetDeletionTimestamp())) {

              		allErrs = append(allErrs, field.Invalid(fldPath.Child("deletionTimestamp"), newMeta.GetDeletionTimestamp(), "field is immutable; may only be changed via deletion"))

              	}

Member

tallclair Mar 26, 2018

These last 2 checks aren't necessary anymore?

Member Author

liggitt Mar 26, 2018

the two fields are verified immutable below

Member

tallclair commented Mar 26, 2018

/lgtm

k8s-ci-robot assigned tallclair

k8s-ci-robot added the lgtm label

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

14 similar comments

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 27, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 28, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 28, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 28, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 28, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 28, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 28, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Mar 28, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

8 similar comments

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 6, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot commented Apr 7, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

liggitt force-pushed the uid-conflict branch from 7b5118f to c245f5c Compare

April 7, 2018 02:03

k8s-ci-robot added size/L and removed lgtm size/M labels

Member Author

liggitt commented Apr 7, 2018

service registry was calling ValidateServiceUpdate for its side-effects... changed that to rest.BeforeCreate(..., service.Strategy). @smarterclayton PTAL

liggitt force-pushed the uid-conflict branch from c245f5c to 159409e Compare

April 7, 2018 02:15

Contributor

k8s-ci-robot commented Apr 7, 2018 •

edited

@liggitt: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-100-performance	7b5118fa0381c7f999476c95fd1e8b6531414b7e	link	`/test pull-kubernetes-e2e-gce-100-performance`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Member Author

liggitt commented Apr 11, 2018

/retest

Member Author

liggitt commented Apr 24, 2018

@smarterclayton friendly ping


          Deprecate repair-malformed-updates flag, move object meta mutation in…

7f840f4

…to BeforeCreate

liggitt force-pushed the uid-conflict branch from 159409e to 7f840f4 Compare

April 27, 2018 21:26

Member Author

liggitt commented May 1, 2018

@kubernetes/sig-api-machinery-pr-reviews

k8s-ci-robot added the sig/api-machinery label

Contributor

smarterclayton commented May 3, 2018

/lgtm

k8s-ci-robot assigned smarterclayton

k8s-ci-robot added the lgtm label

Contributor

k8s-ci-robot commented May 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kube-apiserver/OWNERS~~ [liggitt,smarterclayton]
~~pkg/apis/core/OWNERS~~ [liggitt,smarterclayton]
~~pkg/registry/OWNERS~~ [liggitt,smarterclayton]
~~staging/src/k8s.io/apimachinery/pkg/OWNERS~~ [liggitt,smarterclayton]
~~staging/src/k8s.io/apiserver/OWNERS~~ [liggitt,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-github-robot commented May 3, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot commented May 3, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-github-robot merged commit 4e3efbe into kubernetes:master

liggitt deleted the uid-conflict branch

May 4, 2018 20:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cncf-cla: yes lgtm release-note-none sig/api-machinery size/L