Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify e2e tests to use priorityClass beta client version & switch priorityClass to beta #63724

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Modify e2e tests to use priorityClass beta client version & switch priorityClass to beta #63724

merged 3 commits into from
Jun 5, 2018

Conversation

ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented May 11, 2018 •
edited

What this PR does / why we need it:
/cc @bsalamat @aveshagarwal @liggitt

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #57471

Special notes for your reviewer:
Once #57963 merges, this could go in.

Release note:

Modify e2e tests to use priorityClass beta version & switch priorityClass feature to beta

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 11, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2018
@ravisantoshgudimetla ravisantoshgudimetla changed the title {WIP} Modify e2e tests to use priorityClass beta version {WIP} Modify e2e tests to use priorityClass beta client version May 14, 2018
@ravisantoshgudimetla ravisantoshgudimetla changed the title {WIP} Modify e2e tests to use priorityClass beta client version {WIP} Modify e2e tests to use priorityClass beta client version & switch priorityClass to beta May 14, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 14, 2018
@ravisantoshgudimetla ravisantoshgudimetla changed the title {WIP} Modify e2e tests to use priorityClass beta client version & switch priorityClass to beta Modify e2e tests to use priorityClass beta client version & switch priorityClass to beta May 15, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2018
@bsalamat bsalamat added this to the v1.11 milestone May 15, 2018
@bsalamat bsalamat added status/approved-for-milestone kind/feature Categorizes issue or PR as related to a new feature. labels May 15, 2018
bsalamat
bsalamat reviewed May 15, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks, @ravisantoshgudimetla!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2018
@bsalamat bsalamat added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 15, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented May 15, 2018 •
edited

Thanks for review @bsalamat. Not related to this PR, shouldn't sig-scheduling-approvers be part of test/owners as we have scheduling directory in test/e2e and test/integration?

@bsalamat
Copy link
Member

Not related to this PR, shouldn't sig-scheduling-approvers be part of test/owners as we have scheduling directory in test/e2e and test/integration?

Apparently, the convention is to add individuals to the test/OWNERS (with the exception of sig-test-approvers). I can try adding myself there.

@ravisantoshgudimetla
Copy link
Contributor Author

Waiting on this PR to be merged to get sig-cli lgtm- #63928. This PR removes versioned printer..

@k8s-github-robot k8s-github-robot removed this from the v1.11 milestone May 19, 2018
@bsalamat
Copy link
Member

@kubernetes/sig-testing-pr-reviews @kubernetes/sig-cluster-lifecycle-api-reviews for approval

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 24, 2018
@bsalamat bsalamat removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 24, 2018
@liggitt
Copy link
Member

liggitt commented May 25, 2018

enabling priority by default is holding until the quota PR is reviewed and merged, correct?

@bsalamat
Copy link
Member

enabling priority by default is holding until the quota PR is reviewed and merged, correct?

The quota PR is not a pre-requisite for enabling priority. At least we never had any such plan, but it would be great if both can be done in 1.11.

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@bsalamat bsalamat added this to the v1.11 milestone May 29, 2018
@bsalamat bsalamat added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 29, 2018
@bsalamat
Copy link
Member

We need to merge this ASAP to enable Beta version of priority and preemption by default and start running e2e tests with the feature.

@timothysc timothysc removed their assignment May 30, 2018
@dims
Copy link
Member

dims commented Jun 1, 2018

/assign @deads2k
/sig node

cc @liggitt @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 1, 2018
@ravisantoshgudimetla
Copy link
Contributor Author

/retest

1 similar comment
@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Jun 4, 2018 •
edited

ping @liggitt - Since #57963 got approval and it is going to merge, can you please approve this PR?

@liggitt
Copy link
Member

liggitt commented Jun 5, 2018 •
edited

/lgtm
the change to use v1beta1 types in the e2e tests looks good to me.

We need to merge this ASAP to enable Beta version of priority and preemption by default and start running e2e tests with the feature.

agreed. can you link to the PR that enables this feature flag, and in which job?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liggitt, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @deads2k @liggitt @ravisantoshgudimetla

Pull Request Labels
  • sig/cluster-lifecycle sig/node sig/scheduling sig/testing: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/feature: New functionality.
Help

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d373eaa into kubernetes:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat left review comments

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@deads2k deads2k

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ravisantoshgudimetla @bsalamat @liggitt @dims @k8s-ci-robot @k8s-github-robot @timothysc @deads2k