Add metadata to kubelet eviction event annotations

[dashpole]

What this PR does / why we need it:
Add annotations to kubelet eviction events. Annotations include
"offending_containers" : comma-seperated list of containers.
"offending_containers_usage": comma-seperated list of usage.
"starved_resource": v1.ResourceName of the starved resource

Special notes for your reviewer:
Adding annotations to events required changing the EventRecorder interface to add a AnnotatedEventf function, which can add annotations to an event.

Release note:

NONE

/assign @dchen1107
cc @mwielgus @schylek @kgrygiel

[dashpole]

/sig node
/kind feature

[dashpole]

/retest

[dchen1107]

I am ok that you introduce an annotation to the event object, and also ok to have some structure to the annotation message for eviction event. The question is that if you are expecting VPA or other tool to parse that message to make some controlling decision. If yes, could you please add a test with a comment, so that later the other developer would break that dependency without any warning.

LGTM

[dashpole]

@dchen1107 I added e2e_node testing for this to the eviction tests. It checks that for each evicted pod:

• The pod has an event with event.Reason == "Evicted"
• The event has an annotation with Key: "starved_resource", Value: the expectedStarvedResource for that test.
• The event has an annotation with Key: "offending_containers", Value: The name of each offending container in the pod.
• The event has an annotation with Key: "offending_containers_usage", Value: The usage of each offending container in the pod. The value must be able to be parsed as a Quantity, and must be larger than the container's request.

[dashpole]

/retest

[schylek]

@dchen1107 Can we get this change in despite code slush?

[dchen1107]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [dchen1107]
• pkg/kubelet/OWNERS [dchen1107]
• staging/src/k8s.io/client-go/OWNERS [dchen1107]
• test/e2e_node/OWNERS [dchen1107]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dashpole]

/priority critical-urgent

[dashpole]

/priority critical-urgent

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@dashpole @dchen1107

Pull Request Labels

• sig/node: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/feature: New functionality.

Help

• Additional instructions
• Commands for setting labels

[dashpole]

/retest

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.