-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client-go/examples/fake-client: add doc.go to fix go build warnings #65411
client-go/examples/fake-client: add doc.go to fix go build warnings #65411
Conversation
The fakeclient package does not have any non-test go files. This causes `go build` to give a warning: `no non-test Go files in ...`. This also causes the publishing bot to fail. This PR adds a dummy doc.go file in the package to avoid this warning.
fyi @misterikkit |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Automatic merge from submit-queue (batch tested with PRs 63773, 65411). If you want to cherry-pick this change to another branch, please follow the instructions here. |
@nikhita: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Just confirming here that the publishing bot works fine now. 👍 |
The publishing bot is currently broken (#56876 (comment)). This is due to the following error:
The fakeclient package does not have any non-test go files. The test file was added in #65291 2 days ago.
This causes
go build
to give a warning:no non-test Go files in /go-workspace/src/k8s.io/client-go/examples/fake-client
, which breaks the publishing bot. This PR adds a dummy doc.go file in the package to avoid this warning and fix the publishing bot.Release note: