Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor custom transport dialer #65547

Merged
merged 1 commit into from Jun 28, 2018
Merged

Honor custom transport dialer #65547

merged 1 commit into from Jun 28, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 27, 2018 •
edited

#60012 updated API machinery code to use context dial functions by default, but we should still fall back to honor transport.Dial if set

  • SetOldTransportDefaults should not use the default http DialContext if a custom Dial method is already set
  • DialerFor should prefer DialContext, but fall back to returning a custom Dial if set before returning nil
api-machinery utility functions `SetTransportDefaults` and `DialerFor` once again respect custom Dial functions set on transports

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2018
@liggitt
Copy link
Member Author

liggitt commented Jun 27, 2018

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 27, 2018

/kind bug
/sig api-machinery
/assign @ash2k

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 27, 2018
@liggitt
Copy link
Member Author

liggitt commented Jun 28, 2018

/retest

1 similar comment
@nikhita
Copy link
Member

nikhita commented Jun 28, 2018

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2018
ash2k
ash2k approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@ash2k ash2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry for the breakage.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ash2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member

nikhita commented Jun 28, 2018

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ee2e11a into kubernetes:master Jun 28, 2018
@fedebongio
Copy link
Contributor

/cc @cheftako

@fedebongio
Copy link
Contributor

fedebongio commented Jun 28, 2018 •
edited

/cc @yliaog @roycaihw

@liggitt liggitt deleted the dial-util branch June 28, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ash2k ash2k ash2k approved these changes

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@ash2k ash2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @nikhita @k8s-ci-robot @k8s-github-robot @fedebongio @ash2k