fill in normal restmapping info with the legacy guess #66249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/api-machinery
|
👍 |
deads2k
force-pushed
the
cli-03-restmapper
branch
from
9d09ba3
to
4f2d7dc
Compare
k8s-ci-robot
added
size/S
deads2k
force-pushed
the
cli-03-restmapper
branch
from
4f2d7dc
to
0aa13d7
Compare
|
@smarterclayton related to your bug #65718 |
|
/assign @caesarxuchao |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
This was referenced Aug 10, 2018
When subresource is given, non-conventional CRD resource pluralization not working in kubectl
#67235
Closed
Merged
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 15, 2018
…9-upstream-release-1.11 Automatic merge from submit-queue. Automated cherry pick of #66249: fill in normal restmapping info with the legacy guess Fixes 1.11 part of #67235 Cherry pick of #66249 on release-1.11. #66249: fill in normal restmapping info with the legacy guess ```release-note Fix creation of custom resources when the CRD contains non-conventional pluralization and subresources ```
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 17, 2018
…9-upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #66249: fill in normal restmapping info with the legacy guess Fixes 1.10 part of #67235 Cherry pick of #66249 on release-1.10. #66249: fill in normal restmapping info with the legacy guess ```release-note Fix creation of custom resources when the CRD contains non-conventional pluralization and subresources ```
k8s-ci-robot
added
release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DirectXMan12 noted this here: #65718 (comment)
The code does look wrong. This tries to fix it up
@kubernetes/sig-api-machinery-bugs