Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default extensions/v1beta1 Deployment's RevisionHistoryLimit to MaxInt32 #66605

Merged
merged 3 commits into from Oct 8, 2018
Merged

Default extensions/v1beta1 Deployment's RevisionHistoryLimit to MaxInt32 #66605

merged 3 commits into from Oct 8, 2018

Conversation

islinwb
Copy link
Contributor

@islinwb islinwb commented Jul 25, 2018 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
#66582: fix extensions/v1beta1 Deployment .spec.revisionHistoryLimit

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 25, 2018
@islinwb
Copy link
Contributor Author

islinwb commented Jul 25, 2018

/assign @janetkuo

@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jul 25, 2018
@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from 35eec44 to 57cb575 Compare July 25, 2018 11:34
@islinwb islinwb mentioned this pull request Jul 26, 2018
Closed
5 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2018
janetkuo
janetkuo reviewed Aug 9, 2018
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Most parts of it look like a copy of #66581. Please follow the updated changes made in that PR.

You'll also need to regenerate API docs. Please also update unit test for cleanupDeployment in sync_test.go

@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from 57cb575 to 64b8268 Compare August 10, 2018 02:33
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 10, 2018
@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from 64b8268 to c582f3d Compare August 10, 2018 02:34
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2018
@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from c582f3d to c4c6a10 Compare August 10, 2018 02:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2018
@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from c4c6a10 to cc673a8 Compare August 10, 2018 02:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2018
@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from cc673a8 to f1f5b67 Compare August 10, 2018 02:45
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2018
@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from 1c4b63e to 201a3ec Compare August 10, 2018 03:19
@islinwb
Copy link
Contributor Author

islinwb commented Aug 10, 2018

/retest

@islinwb
Copy link
Contributor Author

islinwb commented Aug 10, 2018

@janetkuo Thanks! I've updated it accordingly.

janetkuo
janetkuo reviewed Aug 13, 2018
View reviewed changes
pkg/controller/deployment/sync_test.go Outdated
@@ -393,6 +394,16 @@ func TestDeploymentController_cleanupDeployment(t *testing.T) {
revisionHistoryLimit: 0,
expectedDeletions: 0,
},
{
// with default revisionHistoryLimit
Copy link
Member

@janetkuo janetkuo Aug 13, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change "default" to "unlimited", because "default values" can be different in different versions of Deployment API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janetkuo Addressed. Thanks!

@janetkuo
Copy link
Member

janetkuo commented Aug 13, 2018 •
edited

One last comment; LGTM otherwise.

@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from 201a3ec to 490d1b3 Compare August 14, 2018 01:19
@islinwb islinwb force-pushed the default_RevisionHistoryLimit branch from 490d1b3 to 84ff6c3 Compare August 14, 2018 01:21
@islinwb
Copy link
Contributor Author

islinwb commented Aug 14, 2018

/retest

@islinwb
Copy link
Contributor Author

islinwb commented Aug 14, 2018

/test pull-kubernetes-e2e-kops-aws

1 similar comment
@islinwb
Copy link
Contributor Author

islinwb commented Aug 14, 2018

/test pull-kubernetes-e2e-kops-aws

@janetkuo
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@islinwb
Copy link
Contributor Author

islinwb commented Aug 15, 2018

/test pull-kubernetes-e2e-kops-aws

@janetkuo
Copy link
Member

/assign @smarterclayton for approval

@k8s-ci-robot
Copy link
Contributor

@janetkuo: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @smarterclayton for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@janetkuo
Copy link
Member

janetkuo commented Oct 5, 2018

/test pull-kubernetes-verify

@islinwb
Copy link
Contributor Author

islinwb commented Oct 8, 2018

/assign @thockin

@thockin
Copy link
Member

thockin commented Oct 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: islinwb, janetkuo, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8fa5d38 into kubernetes:master Oct 8, 2018
@islinwb islinwb deleted the default_RevisionHistoryLimit branch October 9, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@pmorie pmorie Awaiting requested review from pmorie

Assignees

@smarterclayton smarterclayton

@janetkuo janetkuo

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@islinwb @janetkuo @k8s-ci-robot @k8s-github-robot @thockin @smarterclayton