#50102 Task 1: Move apimachinery/pkg/watch.Until into client-go/tools/watch.UntilWithoutRetry #66906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
kind/bug
k8s-ci-robot
removed
the
needs-rebase
tnozicka
changed the title
|
/test pull-kubernetes-kubemark-e2e-gce-big |
|
/retest |
|
/assign @wenjiaswe |
|
@fedebongio: GitHub didn't allow me to assign the following users: wenjiaswe. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Didn't we discuss this before? Why this move? /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Also many people use this helper I would expect. This move breaks them. |
I recall discussing where to put it, thought client-go was what you recommended unless I got you wrong.
Renaming was the consensus between reviewers on #50102. The move is necessary because of import restrictions and because the other Until* functions need to include informers. a) moving the package breaks them anyways I don't want to break them twice by moving the function for v1.12 and renaming it in 1.13 where the rest of usages will be replaced and also having to rename the Retry function back to Until. That's why also the rename now since we are already breaking them with package move. |
|
/cancel hold Missed this reasoning in the PR description. Please provide a |
|
[MILESTONENOTIFIER] Milestone Pull Request Needs Approval @tnozicka @kubernetes/sig-api-machinery-misc Action required: This pull request must have the Pull Request Labels
|
k8s-ci-robot
added
the
needs-rebase
|
/sig api-machinery |
|
Automatic merge from submit-queue (batch tested with PRs 67071, 66906, 66722, 67276, 67039). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from #50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs #66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from)
k8s-publishing-bot
added a commit
to kubernetes/apimachinery
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/client-go
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/kube-aggregator
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/sample-controller
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
sttts
pushed a commit
to sttts/apimachinery
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
sttts
pushed a commit
to sttts/client-go
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
sttts
pushed a commit
to sttts/apiserver
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
sttts
pushed a commit
to sttts/kube-aggregator
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
sttts
pushed a commit
to sttts/sample-apiserver
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
sttts
pushed a commit
to sttts/sample-controller
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
sttts
pushed a commit
to sttts/apiextensions-apiserver
that referenced
this pull request
Sep 5, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/apimachinery
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/client-go
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/apiserver
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/kube-aggregator
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/sample-apiserver
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/sample-controller
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
k8s-publishing-bot
added a commit
to kubernetes/apiextensions-apiserver
that referenced
this pull request
Sep 6, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
wking
added a commit
to wking/kubernetes
that referenced
this pull request
Oct 29, 2018
3d4a02a (Rename Until to UntilWithoutRetry, 2018-08-02, kubernetes#66906) performed the rename it claimed, after which there was no longer an Until function in this package. 3d4a02a had been spun out of [1], which is still in flight with an improved Until [2]. But until that lands, don't reference it in the godocs ;). [1]: kubernetes#50102 [2]: kubernetes@a241de7#diff-b7ca7f71d0c92e184f946e29d5734a4eR96
tamalsaha
pushed a commit
to kmodules/shared-informer
that referenced
this pull request
Aug 13, 2020
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. #50102 Task 2: Add UntilWithSync **What this PR does / why we need it**: This is a split off from kubernetes/kubernetes#50102 to go in smaller pieces. Introduces UntilWithSync based on informer. **Needs kubernetes/kubernetes#66906 first** /hold **Release note**: ```release-note NONE ``` /priority important-soon /kind bug (bug after the main PR which is this split from) Kubernetes-commit: c4f355a2ad9692f5459541d4e4d94fcbc5f7d946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a split off from #50102 to go in smaller pieces.
Moves
apimachinery/pkg/watch.Untilintoclient-go/tools/watch.UntilWithoutRetryand adds context so it is cancelable.Release note:
Dev release note:
/cc @smarterclayton @kubernetes/sig-api-machinery-pr-reviews
/milestone v1.12
/priority important-soon
/kind bug
(bug after the main PR which is this split from)