Rename KubeConfigFile to Kubeconfig in ClientConnectionConfiguration #67149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
sig/scheduling
k8s-github-robot
added
the
kind/api-change
luxas
force-pushed
the
clientconfig_kubeconfig
branch
from
0ff20c9
to
2ff9bd6
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
bsalamat
reviewed
Aug 8, 2018
| // kubeConfigFile is the path to a kubeconfig file. | ||
| KubeConfigFile string `json:"kubeconfig"` | ||
| // kubeconfig is the path to a KubeConfig file. | ||
| Kubeconfig string `json:"kubeconfig"` |
There was a problem hiding this comment.
I guess we are not worried about backward compatibility issues here, right?
There was a problem hiding this comment.
actually, the json name is the same. So, NVM.
There was a problem hiding this comment.
No, we aren't. However, the JSON is backwards-compatible with this change.
This is all alpha, and we're trying to get to a state where we can move types out, do a full field-by-field review on everything, change stuff if needed and then graduate individual components' types to v1beta1 and higher.
There was a problem hiding this comment.
Sounds good. I already approved. Thanks!
k8s-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, liggitt, luxas, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
|
Automatic merge from submit-queue (batch tested with PRs 67061, 66589, 67121, 67149). If you want to cherry-pick this change to another branch, please follow the instructions here. |
5 tasks
15 tasks
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 15, 2018
Automatic merge from submit-queue (batch tested with PRs 67071, 66906, 66722, 67276, 67039). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove references to the structs that have moved to their own packages **What this PR does / why we need it**: Follows-up #66058 and #66059 to remove the structs that now aren't needed in `pkg/apis/componentconfig` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: xref kubernetes/community#2354 **Special notes for your reviewer**: This PR depends on: - [x] #67090 - [x] #67149 - [x] #67159 - [x] #67207 **Only review commit 'Remove references to the structs that have moved to their own packages' please** **Release note**: ```release-note NONE ``` /kind cleanup /assign @sttts @thockin @jbeda @liggitt
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 2, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Refactor the kube-controller-manager ComponentConfig structs **What this PR does / why we need it**: This PR cleans up the kube-controller-manager structs in the componentconfig package and fixes various structural issues in the current code, in order to make it possible to later move the code out to external API groups (as a starting point `GenericControllerManagerConfiguration` to `k8s.io/controller-manager`). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: kubernetes/community#2354 This PR depends on: - [x] #67149 - [x] #67090 - [x] #67159 - [x] #67207 - [x] #66722 **Special notes for your reviewer**: Please only review the following commits: - **Refactor the k-c-m ComponentConfig structs to they can be moved out** - **Fixup cmd/kube-controller-manager code after struct changes.** **Release note**: ```release-note NONE ``` /assign @sttts @stewart-yu @liggitt @thockin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As discussed with @liggitt we should make the field name and JSON tag consistent, and we concluded
Kubeconfigandkubeconfigis the most consistent naming we have (e.g. wrt--kubeconfig), so we're going with that naming for theClientConnectionConfigurationstruct. Also, this preserves backwards-compat wrt existing serialized configuration. This fixes the API violation.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):ref: kubernetes/community#2354
Special notes for your reviewer:
Release note:
/assign @liggitt @sttts