update Annotations description about audit.Event #67386
Conversation
k8s-ci-robot
added
release-note-none
| // admission plugins. Keys should uniquely identify the informing component to avoid name | ||
| // collisions (e.g. podsecuritypolicy.admission.k8s.io/policy). Values should be short. Annotations | ||
| // are included in the Metadata level. | ||
| // admission plugins. But it does not contain the annotations of the submitted object. |
There was a problem hiding this comment.
suggest "Note that these annotations are for the audit event, and do not correspond to the metadata.annotations of the submitted object."
There was a problem hiding this comment.
also update v1alpha1 and v1beta1 audit types?
CaoShuFeng
force-pushed
the
audit_annotation_object
branch
from
4df545b
to
2c19a5d
Compare
|
/test pull-kubernetes-e2e-kops-aws |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CaoShuFeng, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@CaoShuFeng: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 55600, 67386). If you want to cherry-pick this change to another branch, please follow the instructions here. |
ref: #58679 (comment)
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/assign @liggitt
Release note: