Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstructured metadata accessors to respect omitempty semantics #67635

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Fix unstructured metadata accessors to respect omitempty semantics #67635

merged 2 commits into from
Aug 22, 2018

Commits on Aug 21, 2018

  1. Fix unstructured metadata accessors to respect omitempty semantics 

    ObjectMeta has fields with omitempty json tags. This means that when
the fields have zero values, they should not be persisted in the object.

Before this commit, some of the metadata accessors for unstructured
objects did not respect these semantics i.e they would persist a field
even if it had a zero value.

This commit updates the accessors so that the field is removed from the
unstructured object map if it contains a zero value.
    @nikhita
    nikhita committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    f69544e View commit details
    Browse the repository at this point in the history

  2. Fix tests to support ObjectMeta omitempty semantics

    @nikhita
    nikhita committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    dabd56f View commit details
    Browse the repository at this point in the history