Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PersistentVolumes-local symlink upgrade tests #68371

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Fix PersistentVolumes-local symlink upgrade tests #68371

merged 1 commit into from
Sep 10, 2018

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Sep 6, 2018

What this PR does / why we need it:
#63011 added a stat call on the local volume path in order to determine if it is a file or a block device. This means that kubelet needs permissions on the volume in order to stat it. This PR updates the e2e test to create the local volume with root permissions so that kubelet can stat it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68314

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

@msau42:
This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.
To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.
The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2018
@msau42
Copy link
Member Author

msau42 commented Sep 6, 2018

/assign @davidz627

@msau42
Copy link
Member Author

msau42 commented Sep 6, 2018

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2018
@msau42 msau42 mentioned this pull request Sep 6, 2018
Closed
@msau42
Copy link
Member Author

msau42 commented Sep 6, 2018

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 6, 2018
@davidz627
Copy link
Contributor

/lgtm
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saad-ali saad-ali added this to the v1.11 milestone Sep 6, 2018
@davidz627
Copy link
Contributor

/retest

@guineveresaenger
Copy link
Contributor

guineveresaenger commented Sep 6, 2018 •
edited

@davidz627 can you address test failures?

@msau42
Copy link
Member Author

msau42 commented Sep 6, 2018

@guineveresaenger I don't think david is the right person to look into the gpu test failures. I see there's already a bug open for it #68372

@guineveresaenger
Copy link
Contributor

guineveresaenger commented Sep 6, 2018 •
edited

thanks @msau appreciated. i didn't realize it was a testbug-in-a-testbug.

@foxish foxish added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 6, 2018
@msau42
Copy link
Member Author

msau42 commented Sep 6, 2018

/assign @foxish

@msau42 msau42 changed the title Port e2e test changes from #63011 that created symlinks as root Fix PersistentVolumes-local symlink upgrade tests Sep 6, 2018
@msau42
Copy link
Member Author

msau42 commented Sep 10, 2018

/retest

@foxish foxish added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 10, 2018
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-ci-robot k8s-ci-robot merged commit c4942df into kubernetes:release-1.11 Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@verult verult Awaiting requested review from verult

Assignees

@foxish foxish

@davidz627 davidz627

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@msau42 @k8s-ci-robot @davidz627 @guineveresaenger @k8s-github-robot @foxish @saad-ali