-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean the deprecated func Parallelize #76595
Conversation
/assign @cheftako |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But we must also ensure that Parallelize is not called by others. It may also be a good idea to remove the deprecated statement and keep it.
I will leave lgtm to @sttts
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielqsj, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig cloud-provider |
I think we need to start having a better policy for handling deprecated APIs than just its major version bump to client-go so we can delete it 1 quarter later. Also no references in K/K is an increasingly poor signal as to usage. Most of our cloud providers are NOT is K/K and hopefully soon none of the cloud providers will be in K/K. Given that most cloud providers are running about two releases behind, this implies that the API will have changed a quarter before the user reasonably has a chance to object. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I find the func
Parallelize
was deprecated in v1.13 by #68403. And no reference in k/k repo.I think it's safe to clean it in v1.15.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: