Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for yaml marshaling and unmarshaling #78688

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Add benchmarks for yaml marshaling and unmarshaling #78688

merged 1 commit into from
Sep 21, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 4, 2019

Related: kubernetes-sigs/yaml#19

/kind cleanup
/cc @liggitt @dims @neolit123 @sttts

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 4, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 4, 2019
@nikhita nikhita mentioned this pull request Jun 4, 2019
Closed
@nikhita
Copy link
Member Author

nikhita commented Jun 4, 2019

/sig api-machinery
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 4, 2019
@fedebongio
Copy link
Contributor

/cc @jpbetz @jennybuckley
/sig scalability
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 6, 2019
@dims
Copy link
Member

dims commented Jul 8, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims July 8, 2019 15:42
neolit123
neolit123 reviewed Aug 4, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2019
@dims
Copy link
Member

dims commented Aug 5, 2019

/assign @erictune @liggitt

@liggitt
Copy link
Member

liggitt commented Sep 20, 2019

/approve
/test all

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2e13dfa into kubernetes:master Sep 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@liggitt liggitt Awaiting requested review from liggitt

@sttts sttts Awaiting requested review from sttts

@jennybuckley jennybuckley Awaiting requested review from jennybuckley

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@neolit123 neolit123

@liggitt liggitt

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@nikhita @fedebongio @dims @liggitt @k8s-ci-robot @fejta-bot @neolit123 @erictune