-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update cAdvisor to v0.38.6 #97175
vendor: update cAdvisor to v0.38.6 #97175
Conversation
Signed-off-by: Hanlin Shi <shihanlin9@gmail.com>
Hi @hanlins. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
2 similar comments
/retest |
/retest |
/lgtm |
/assign @dims |
/assign @dchen1107 |
/approve |
/lgtm |
/priority important-soon should add a release note indicating the issue being fixed |
/lgtm |
/sig node |
cc @kubernetes/release-managers |
cc @kubernetes/release-engineering |
/assign @hasheddan @justaugustus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, dims, hanlins, hasheddan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Bug fix for cAdvisor exponential backoff. Originally backoff multiplier defaults to zero, causing backoff timeout drop to zero after the first retry, causing retries flooding. Before the fix, kubelet experienced issue that CPU will spike to 100% after restarting containerd.
Which issue(s) this PR fixes:
Fixes #95727
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
cc @bobbypage