New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package/containerd-bin: update hash #14047
package/containerd-bin: update hash #14047
Conversation
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Hi @eiffel-fl. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eiffel-fl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @afbjorklund |
Can one of the admins verify this patch? |
The problem is upstream. |
Hum sad... Nonetheless, what about using the same way of getting as upstream? |
I will close it to avoid noise as my contribution will, sadly, not solve the problem but we can still discuss on how to find a solution to this problem. |
containerd 1.4 and 1.6 don't have the problem But otherwise upstream use the same tarball hashes |
My hypothesis is they are not impacted by the bug we hit because they create the tarball themselves from the git repo instead of directly get the tarball. |
Not sure what you mean, the only difference is that they have proper tarball naming. The reason why they are not affected is that containerd 1.6 changed from the short hash to the long hash. |
What is this short vs long hash difference? |
Hi.
I had troubles building minikube ISO with
containerd-bin
because its hash is not good.So, I updated it.
Can you please check if you have the problem on your side?
Best regards.