Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package/containerd-bin: update hash #14047

Closed

Conversation

eiffel-fl
Copy link
Contributor

Hi.

I had troubles building minikube ISO with containerd-bin because its hash is not good.
So, I updated it.
Can you please check if you have the problem on your side?

Best regards.

Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @eiffel-fl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eiffel-fl
To complete the pull request process, please assign spowelljr after the PR has been reviewed.
You can assign the PR to them by writing /assign @spowelljr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eiffel-fl
Copy link
Contributor Author

cc @afbjorklund

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@afbjorklund
Copy link
Collaborator

@eiffel-fl
Copy link
Contributor Author

Hum sad...
Thank you for pointing it to me.

Nonetheless, what about using the same way of getting as upstream?
If I understood correctly, they first clone the containerd repo at v1.6.2 and creates the archive locally.
Maybe by doing so they avoid the problem you are facing?

@eiffel-fl
Copy link
Contributor Author

eiffel-fl commented Apr 26, 2022

I will close it to avoid noise as my contribution will, sadly, not solve the problem but we can still discuss on how to find a solution to this problem.

@eiffel-fl eiffel-fl closed this Apr 26, 2022
@eiffel-fl eiffel-fl deleted the francis/fix-containerd-bin-hash branch April 26, 2022 10:07
@afbjorklund
Copy link
Collaborator

afbjorklund commented Apr 26, 2022

containerd 1.4 and 1.6 don't have the problem

But otherwise upstream use the same tarball hashes

https://github.com/buildroot/buildroot/blob/2e49ff10202e28a8dc942bfe11d7a623aca0bf6c/package/containerd/containerd.hash

@eiffel-fl
Copy link
Contributor Author

But otherwise upstream use the same tarball hashes

My hypothesis is they are not impacted by the bug we hit because they create the tarball themselves from the git repo instead of directly get the tarball.

@afbjorklund
Copy link
Collaborator

Not sure what you mean, the only difference is that they have proper tarball naming.

The reason why they are not affected is that containerd 1.6 changed from the short hash to the long hash.

@eiffel-fl
Copy link
Contributor Author

The reason why they are not affected is that containerd 1.6 changed from the short hash to the long hash.

What is this short vs long hash difference?
Can you please give me a link to have a better understanding?

@afbjorklund
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants