-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable systemd-binfmt.service in kicbase. #18456
base: master
Are you sure you want to change the base?
Conversation
Due to minikube running as a priviledged container, binfmt_misc not being namespaced in the kernel and due to kicbase running the systemd-binfmt.service (binfmt.d), the minikube container at startup will reset the registered binfmt interpreters on the host machine.
|
Welcome @hpidcock! |
Hi @hpidcock. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, hpidcock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube ingress: 24.5s 23.6s 23.6s 23.5s 26.1s Times for minikube start: 51.5s 53.1s 51.9s 49.8s 51.3s docker driver with docker runtime
Times for minikube start: 23.9s 21.8s 21.2s 24.9s 22.0s Times for minikube ingress: 21.3s 20.8s 20.8s 21.3s 21.3s docker driver with containerd runtime
Times for minikube start: 19.5s 22.7s 20.8s 20.5s 22.4s Times for minikube ingress: 31.8s 31.8s 31.8s 20.8s 31.8s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
Due to minikube running as a priviledged container, binfmt_misc not being namespaced in the kernel and due to kicbase running the systemd-binfmt.service (binfmt.d), the minikube container at startup will reset the registered binfmt interpreters on the host machine.
fixes #18455