Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version package in favor of sigs.k8s.io/release-utils/version #2569

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 14, 2022

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

version command

$ krel version
    __ __    ____     ______    __
   / //_/   / __ \   / ____/   / /
  / ,<     / /_/ /  / __/     / /
 / /| |   / _, _/  / /___    / /___
/_/ |_|  /_/ |_|  /_____/   /_____/
krel: The Kubernetes Release toolbox

GitVersion:    v0.14.0
GitCommit:     2588bc18fba1f8ad540df413dc4c816919c905d1
GitTreeState:  dirty
BuildDate:     2022-06-14T02:13:50
GoVersion:     go1.18.3
Compiler:      gc
Platform:      darwin/arm64

/assign @saschagrunert @puerco @Verolop @palnabarun
cc @kubernetes/release-managers

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

remove version package in favor of sigs.k8s.io/release-utils/version 

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 14, 2022
pkg/anago/anago.go Outdated Show resolved Hide resolved
pkg/anago/anago.go Outdated Show resolved Hide resolved
Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d3d54c2 into kubernetes:master Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 14, 2022
@cpanato cpanato deleted the update-version branch June 14, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants