Run ./hack/update-deps.sh --patch

[k8s-ci-robot]

Automatic go module update. Please review

[fejta]

Can we get rid of this dep @clarketm ?

[clarketm]

No, it is required by genyaml (we need it at least until I can create a custom encoder that can handle all this fancy logic 💃).

[fejta]

test-infra/prow/config/config.go

Line 470 in 7b736ad

ResyncPeriod *metav1.Duration `json:"resync_period,omitempty"`

https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/duration.go

[clarketm]

My take is that since GenYaml(...) takes an interface, it can handle any arbitrary type. IMO, it would be impractical to use genyaml if a user had to create a custom marshaller for every struct in the source file(s). It would complicate it and reduce its utility. I am not saying that this/my approach is the best, but it does make the tool much easier to use out-of-the-box.

test-infra/pkg/genyaml/genyaml.go

Line 411 in a3fd5b7

func (cm *CommentMap) GenYaml(config interface{}) (string, error) {

[fejta]

So basically you're just reinventing http://sigs.k8s.io/yaml? Please get rid of this.

[clarketm]

This would not work using http://sigs.k8s.io/yaml because it it outdated and does not support the Node type which it critical to the comment-injection logic of genyaml.

xref: kubernetes-sigs/yaml#18
xref: kubernetes-sigs/yaml#26

[clarketm]

I am not opposed to switching to http://sigs.k8s.io/yaml in the future once these features are supported (assuming it exposes these built-in go-yaml/v3 types and continues to filter zero-values structs).

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, k8s-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment