Fix flake unit test TestAddWithParser #32385
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix #31313.
As far as I was able to understand the test pulled out the value from the
generator
(here) before the agent had the time to update it (here).This solution might not be ideal still, due to the 10s
time.Sleep
but we need to go a pretty extensive refactor to make the test 100% deterministic.Anyway, as far as I know the sleep has never been a problem so far, therefore we might be good this way.