Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CAPI triage #32465

Merged
merged 1 commit into from May 13, 2024
Merged

Improve CAPI triage #32465

merged 1 commit into from May 13, 2024
+16 −9

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Apr 18, 2024 •
edited

  • Restore the triage process configuration to previous configuration
  • Applies needs kind and needs priority labels to issue

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/label_sync Issues or PRs related to code in /label_sync sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 18, 2024
chrischdi
chrischdi reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@sbueringer
Copy link
Member

/cc

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/assign @MadhavJivrajani

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@sbueringer
Copy link
Member

friendly reminder @MadhavJivrajani :)

cblecker
cblecker reviewed May 7, 2024
View reviewed changes
label_sync/labels.yaml
name: triage/needs-discussion
target: both
prowPlugin: label
addedBy: org members
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you wanting this label to be removed? Deleting it from here won't remove it, you need to use a deleteAfter field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We delete it manually from the repo. For CAPI that's okay

MadhavJivrajani
MadhavJivrajani approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @dims
for approval

@MadhavJivrajani
Copy link
Contributor

/assign @cblecker

@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fabriziopandini, MadhavJivrajani, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit e5ff1a8 into kubernetes:master May 13, 2024
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Updated the following 2 configmaps:

  • plugins configmap in namespace default at cluster test-infra-trusted using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml
  • label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:
    • key labels.yaml using file label_sync/labels.yaml

In response to this:

  • Restore the triage process configuration to previous configuration
  • Applies needs kind and needs priority labels to issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

Thx folks!

@fabriziopandini fabriziopandini mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@cblecker cblecker cblecker left review comments

@MadhavJivrajani MadhavJivrajani MadhavJivrajani approved these changes

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@dims dims

@chrischdi chrischdi

@cblecker cblecker

@sbueringer sbueringer

@MadhavJivrajani MadhavJivrajani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fabriziopandini @sbueringer @MadhavJivrajani @cblecker @k8s-ci-robot @chrischdi @dims