add JobSet periodic release and main tests #32532

omerap12 · 2024-04-29T10:09:03Z

…s 0.4 and 0.5

k8s-ci-robot · 2024-04-29T10:09:12Z

Hi @omerap12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

config/jobs/kubernetes-sigs/jobset/jobset-presubmit-release-0.4.yaml

…ng_release_branches

kannon92

/retitle add JobSet periodic release and main tests

kannon92

/ok-to-test

/assign @danielvegamyhre

kannon92 · 2024-04-29T14:58:07Z

LGTM but I’m not by computer so hope @danielvegamyhre can give a second look

kannon92 · 2024-04-29T15:12:59Z

Check linter. You may have duplicate names or indentation issues

omerap12 · 2024-04-29T15:15:35Z

Check linter. You may have duplicate names or indentation issues

Yes, noticed. I'll get home and fix this. Thanks :)

omerap12 · 2024-04-29T16:04:08Z

/retest

kannon92

Ping @danielvegamyhre

omerap12 · 2024-05-05T17:16:53Z

Hey @kannon92 @danielvegamyhre ,
any update?

danielvegamyhre · 2024-05-06T06:10:37Z

Thanks @omerap12 I will take a look at this tomorrow

danielvegamyhre · 2024-05-06T16:01:02Z

@omerap12 did you use any existing tests as a reference when building this? If so can you share them

omerap12 · 2024-05-06T16:06:57Z

@omerap12 did you use any existing tests as a reference when building this? If so can you share them

Yes, this is the presubmit tests for jobset:
https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/jobset/jobset-presubmit.yaml

So I implemented those tests with using a reference from kueue:
https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/kueue

omerap12 · 2024-05-10T12:11:07Z

Hey Guys, any update on this one? @kannon92 @danielvegamyhre

config/jobs/kubernetes-sigs/jobset/jobset-presubmit-release-0.4.yaml

danielvegamyhre · 2024-05-12T01:31:06Z

config/jobs/kubernetes-sigs/jobset/jobset-release-blocking.yaml

@@ -0,0 +1,190 @@
+periodics:


I thought we were just adding periodic tests on the release branches, what are the other presubmit files about?

I thought of adding presubmit checks for release branches as well. I can remove them if you'd like

Would the presubmits only trigger when we are merging a PR into the given release branch? Or does it run unconditionally?

Presubmit jobs runs for pull requests into the given branch. periodic jobs run unconditionally

jobset-presubmit-release-0.4.yaml

…branches

and 0.5

…branches

config/jobs/kubernetes-sigs/jobset/jobset-periodics-release-0-4.yaml

jobset-presubmit YAML files

danielvegamyhre · 2024-05-13T20:39:01Z

config/jobs/kubernetes-sigs/jobset/jobset-periodics-main.yaml

+        - make
+        - test
+        securityContext:
+          privileged: true


any idea why this is necessary?

Because you are running Docker in Docker I think it is necessary

danielvegamyhre · 2024-05-13T23:33:10Z

/lgtm
/approve

Thanks @omerap12!

k8s-ci-robot · 2024-05-13T23:33:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/jobs/kubernetes-sigs/jobset/OWNERS~~ [danielvegamyhre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-05-13T23:35:21Z

@omerap12: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

key jobset-periodics-main.yaml using file config/jobs/kubernetes-sigs/jobset/jobset-periodics-main.yaml
key jobset-periodics-release-0-4.yaml using file config/jobs/kubernetes-sigs/jobset/jobset-periodics-release-0-4.yaml
key jobset-periodics-release-0-5.yaml using file config/jobs/kubernetes-sigs/jobset/jobset-periodics-release-0-5.yaml
key jobset-presubmit.yaml using file ``
key jobset-presubmit-main.yaml using file config/jobs/kubernetes-sigs/jobset/jobset-presubmit-main.yaml
key jobset-presubmit-release-0.4.yaml using file config/jobs/kubernetes-sigs/jobset/jobset-presubmit-release-0.4.yaml
key jobset-presubmit-release-0.5.yaml using file config/jobs/kubernetes-sigs/jobset/jobset-presubmit-release-0.5.yaml

In response to this:

issue: kubernetes-sigs/jobset#524

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danielvegamyhre · 2024-05-14T16:15:20Z

@omerap12 some of the tests added here are failing (example) can you take a look please?

omerap12 · 2024-05-14T16:20:23Z

@omerap12 some of the tests added here are failing (example) can you take a look please?

sure, Ill take a look

omerap12 · 2024-05-14T16:40:17Z

@omerap12 some of the tests added here are failing (example) can you take a look please?

Found the problem. Ill create another PR to fix this soon.

Added periodic jobs for main branch and presubmit for release branche…

1b9b228

…s 0.4 and 0.5

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 29, 2024

k8s-ci-robot requested review from chases2 and dims April 29, 2024 10:09

k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 29, 2024

omerap12 changed the title ~~Added periodic jobs for main branch and presubmit for release branche…~~ Added periodic jobs for main branch and presubmit for release branches Apr 29, 2024

omerap12 mentioned this pull request Apr 29, 2024

Periodic Jobs for Testing Release Branches kubernetes-sigs/jobset#524

Closed

kannon92 reviewed Apr 29, 2024

View reviewed changes

config/jobs/kubernetes-sigs/jobset/jobset-presubmit-release-0.4.yaml Outdated Show resolved Hide resolved

omerap12 added 2 commits April 29, 2024 15:00

Fixed tests name and annotations

68e9bb5

Fixed tests name and annotations

52a636f

omerap12 force-pushed the jobset-added_periodi_jobs_testing_release_branches branch from 9ee346d to 52a636f Compare April 29, 2024 12:22

omerap12 and others added 2 commits April 29, 2024 15:22

Merge branch 'kubernetes:master' into jobset-added_periodi_jobs_testi…

09f190a

…ng_release_branches

Fixed tests name and annotations

12eaaab

omerap12 requested a review from kannon92 April 29, 2024 12:39

kannon92 reviewed Apr 29, 2024

View reviewed changes

k8s-ci-robot changed the title ~~Added periodic jobs for main branch and presubmit for release branches~~ add JobSet periodic release and main tests Apr 29, 2024

kannon92 reviewed Apr 29, 2024

View reviewed changes

k8s-ci-robot assigned danielvegamyhre Apr 29, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024

Fix lint

35177f8

omerap12 requested a review from kannon92 April 29, 2024 18:08

kannon92 reviewed May 2, 2024

View reviewed changes

danielvegamyhre reviewed May 12, 2024

View reviewed changes

config/jobs/kubernetes-sigs/jobset/jobset-presubmit-release-0.4.yaml Outdated Show resolved Hide resolved

danielvegamyhre reviewed May 12, 2024

View reviewed changes

omerap12 added 3 commits May 13, 2024 18:00

Update jobset-presubmit-release-0.5.yaml and

bf1e469

jobset-presubmit-release-0.4.yaml

Merge branch 'master' into jobset-added_periodi_jobs_testing_release_…

b2e9f6e

…branches

Add kind-image-build to tests

390d9ee

omerap12 force-pushed the jobset-added_periodi_jobs_testing_release_branches branch from b032ddc to 390d9ee Compare May 13, 2024 15:11

omerap12 added 2 commits May 13, 2024 19:06

Update jobset names and base refs for release 0.4

d4a849d

and 0.5

Merge branch 'master' into jobset-added_periodi_jobs_testing_release_…

38af0a7

…branches

danielvegamyhre reviewed May 13, 2024

View reviewed changes

config/jobs/kubernetes-sigs/jobset/jobset-periodics-release-0-4.yaml Show resolved Hide resolved

danielvegamyhre reviewed May 13, 2024

View reviewed changes

config/jobs/kubernetes-sigs/jobset/jobset-periodics-release-0-4.yaml Outdated Show resolved Hide resolved

Remove kind-image-build from jobset-periodics and

b984757

jobset-presubmit YAML files

danielvegamyhre reviewed May 13, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024

k8s-ci-robot merged commit a9bd71b into kubernetes:master May 13, 2024
7 checks passed

omerap12 mentioned this pull request May 14, 2024

Fix base_ref in periodics-release Jobset #32616

Merged

omerap12 mentioned this pull request May 23, 2024

REQUEST: New membership for omerap12 kubernetes/org#4974

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add JobSet periodic release and main tests #32532

add JobSet periodic release and main tests #32532

omerap12 commented Apr 29, 2024 •

edited

k8s-ci-robot commented Apr 29, 2024

kannon92 left a comment

kannon92 left a comment

kannon92 commented Apr 29, 2024

kannon92 commented Apr 29, 2024

omerap12 commented Apr 29, 2024

omerap12 commented Apr 29, 2024

kannon92 left a comment

omerap12 commented May 5, 2024

danielvegamyhre commented May 6, 2024

danielvegamyhre commented May 6, 2024

omerap12 commented May 6, 2024 •

edited

omerap12 commented May 10, 2024

danielvegamyhre May 12, 2024

omerap12 May 13, 2024

danielvegamyhre May 13, 2024

omerap12 May 13, 2024

danielvegamyhre May 13, 2024

danielvegamyhre May 13, 2024

omerap12 May 13, 2024

danielvegamyhre May 13, 2024

danielvegamyhre commented May 13, 2024

k8s-ci-robot commented May 13, 2024

k8s-ci-robot commented May 13, 2024

danielvegamyhre commented May 14, 2024

omerap12 commented May 14, 2024

omerap12 commented May 14, 2024

add JobSet periodic release and main tests #32532

add JobSet periodic release and main tests #32532

Conversation

omerap12 commented Apr 29, 2024 • edited

k8s-ci-robot commented Apr 29, 2024

kannon92 left a comment

Choose a reason for hiding this comment

kannon92 left a comment

Choose a reason for hiding this comment

kannon92 commented Apr 29, 2024

kannon92 commented Apr 29, 2024

omerap12 commented Apr 29, 2024

omerap12 commented Apr 29, 2024

kannon92 left a comment

Choose a reason for hiding this comment

omerap12 commented May 5, 2024

danielvegamyhre commented May 6, 2024

danielvegamyhre commented May 6, 2024

omerap12 commented May 6, 2024 • edited

omerap12 commented May 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielvegamyhre commented May 13, 2024

k8s-ci-robot commented May 13, 2024

k8s-ci-robot commented May 13, 2024

danielvegamyhre commented May 14, 2024

omerap12 commented May 14, 2024

omerap12 commented May 14, 2024

omerap12 commented Apr 29, 2024 •

edited

omerap12 commented May 6, 2024 •

edited