Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image pushing job for cloud provider vsphere #32590

Conversation

XudongLiuHarold
Copy link
Member

  • Add image pushing job for cloud provider vsphere

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 9, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2024
@XudongLiuHarold XudongLiuHarold force-pushed the add-image-pushing-job-for-cloud-provider-vsphere branch 3 times, most recently from 9f7ce7c to ac20e62 Compare May 9, 2024 07:14
@XudongLiuHarold
Copy link
Member Author

Hi @ameukam, could you review this one when you are available? Thank you! ❤️

@XudongLiuHarold
Copy link
Member Author

/assign @ameukam @test-infra-oncall

@k8s-ci-robot
Copy link
Contributor

@XudongLiuHarold: GitHub didn't allow me to assign the following users: test-infra-oncall.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ameukam @test-infra-oncall

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks perfect

Signed-off-by: xudong liu <xudong.liu@broadcom.com>
@XudongLiuHarold XudongLiuHarold force-pushed the add-image-pushing-job-for-cloud-provider-vsphere branch from ac20e62 to dfb20a0 Compare May 15, 2024 02:52
@sbueringer
Copy link
Member

Thx!
/lgtm

/assign @dims

(Context: this is part of our work to move to community infra)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@ameukam
Copy link
Member

ameukam commented May 15, 2024

/approve
/hold

Remove the hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@XudongLiuHarold
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 570b0fb into kubernetes:master May 15, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@XudongLiuHarold: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-cloud-provider-vsphere.yaml using file config/jobs/image-pushing/k8s-staging-cloud-provider-vsphere.yaml

In response to this:

  • Add image pushing job for cloud provider vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants