Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note needed in "Using a Service to Expose Your App > Step 3: Deleting a service" #46292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishalbidwe
Copy link
Contributor

@vishalbidwe vishalbidwe commented May 9, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 9, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 9, 2024
Copy link

netlify bot commented May 9, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8db91ef
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663cd0ed12df0f0008889f52
😎 Deploy Preview https://deploy-preview-46292--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

Note, if you add the following line to your PR description:

Closes: #46105 

It will automatically link this PR to the issue so it is visible, and when this PR merges it will automatically close the issue it is addressing.

@vishalbidwe
Copy link
Contributor Author

@stmcginnis Thanks for providing input I'll add Closes: Issue No line in description from onwards and updated description for this PR as well :)

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am putting this PR on hold since the issue submitter hasn't clarified why there is a requirement for this line.
There's already an existing comment that explicitly asks the user to confirm that the service is gone before following the next steps.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note needed in "Using a Service to Expose Your App > Step 3: Deleting a service"
4 participants