Update glossary_tooltip.html to include relLangURL for $external_link #46306
Conversation
k8s-ci-robot
added
the
sig/docs
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
area/web-development
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| {{- $tooltip := $tooltip | replaceRE "(?s)<a class='glossary-tooltip'.*?>(.*?).*</a>" "$1" | plainify -}} | |||
| {{- $tooltip := trim $tooltip " \n" -}} | |||
| <a class='glossary-tooltip' title='{{- $tooltip | safeHTML -}}' data-toggle='tooltip' data-placement='top' href='{{ $external_link }}' target='_blank' aria-label='{{ $text }}'> | |||
| <a class='glossary-tooltip' title='{{- $tooltip | safeHTML -}}' data-toggle='tooltip' data-placement='top' href='{{ $external_link | relLangURL }}' target='_blank' aria-label='{{ $text }}'> | |||
There was a problem hiding this comment.
If someone wants to link to an English page explicitly (because there's no localized version of it yet), does that still work?
There was a problem hiding this comment.
It doesn't matter due to the rules upon which the glossary page is built.
Let's take the Polish language as an example, https://deploy-preview-46306--kubernetes-io-main-staging.netlify.app/pl/docs/reference/glossary/?all=true#term-api-group — there is no file content/pl/docs/reference/glossary/api-group.md and English version is incorporated instead.
|
/area localization |
k8s-ci-robot
added
the
area/localization
This fine-tuning will help to avoid explicit manual language prefixing for the
full_link. This change does not affect already language prefixedfull_link(e.g. zh-cn)