Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct link for removed feature gate #46311

Merged
merged 1 commit into from May 13, 2024

Conversation

Atomsoldat
Copy link
Contributor

The LegacyServiceAccountTokenNoAutoGeneration feature gate has been removed and no longer appears in the list of deprecated feature gates as a result of that. When talking about this feature gate, content/en/docs/concepts/security/service-accounts.md still links to the list of deprecated feature gates.

I think it would be better if the link pointed to the list of removed feature gates, where this feature gate actually appears; hence this request.

Copy link

linux-foundation-easycla bot commented May 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Atomsoldat!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 10, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tengqm May 10, 2024 15:44
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 10, 2024
Copy link

netlify bot commented May 10, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bd6541b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66404ebfc9a5320008b6bb32
😎 Deploy Preview https://deploy-preview-46311--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

Since the feature gate this text requires is now removed, I think this section may need to be reworked rather than pointing to old information. Could you look at that instead?

We do need a signed CLA to accept any changes, so that will need to be done before any PRs can be accepted. If you have any questions not answered by the links provided from the bot, please do ask here or in Slack.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 10, 2024
@@ -183,7 +183,7 @@ following methods:
Secrets in Pods. These tokens don't expire and don't rotate.
This method is not recommended, especially at scale, because of the risks associated
with static, long-lived credentials. In Kubernetes v1.24 and later, the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version range can be made more specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature gate is removed in the current versions, but not in old ones. That is how I stumbled upon the outdated link, because I was upgrading from 1.26. So i think it is still useful to have information about it, at least for a while. I have tried to clarify the version ranges and rewrote some of the prose to be more helpful in my opinion.

@stmcginnis I can rewrite the text further, but then it would be good to know what you would consider appropriate.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2024
@tengqm
Copy link
Contributor

tengqm commented May 12, 2024

/lgtm
The message is clear and accurate.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7a50800b202de1e82326bd7a412fe87095cb1e2

@salaxander
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: salaxander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit bb4e19a into kubernetes:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants