New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct link for removed feature gate #46311
Conversation
|
Welcome @Atomsoldat! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Since the feature gate this text requires is now removed, I think this section may need to be reworked rather than pointing to old information. Could you look at that instead? We do need a signed CLA to accept any changes, so that will need to be done before any PRs can be accepted. If you have any questions not answered by the links provided from the bot, please do ask here or in Slack. |
@@ -183,7 +183,7 @@ following methods: | |||
Secrets in Pods. These tokens don't expire and don't rotate. | |||
This method is not recommended, especially at scale, because of the risks associated | |||
with static, long-lived credentials. In Kubernetes v1.24 and later, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version range can be made more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature gate is removed in the current versions, but not in old ones. That is how I stumbled upon the outdated link, because I was upgrading from 1.26
. So i think it is still useful to have information about it, at least for a while. I have tried to clarify the version ranges and rewrote some of the prose to be more helpful in my opinion.
@stmcginnis I can rewrite the text further, but then it would be good to know what you would consider appropriate.
2db1a6a
to
6c90bd7
Compare
…eration feature gate
6c90bd7
to
bd6541b
Compare
/lgtm |
LGTM label has been added. Git tree hash: d7a50800b202de1e82326bd7a412fe87095cb1e2
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: salaxander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
LegacyServiceAccountTokenNoAutoGeneration
feature gate has been removed and no longer appears in the list of deprecated feature gates as a result of that. When talking about this feature gate,content/en/docs/concepts/security/service-accounts.md
still links to the list of deprecated feature gates.I think it would be better if the link pointed to the list of removed feature gates, where this feature gate actually appears; hence this request.