Render favicons using Hugo Pipes #46325
Conversation
k8s-ci-robot
added
the
area/web-development
k8s-ci-robot
added
the
sig/docs
k8s-ci-robot
added
cncf-cla: yes
sftim
force-pushed
the
20240511_favicon_hugo_pipes
branch
from
a4db38c
to
9e271ed
Compare
| @@ -0,0 +1 @@ | |||
| <link rel="manifest" href="/manifest.webmanifest"> | |||
There was a problem hiding this comment.
Previously found within layouts/partials/favicons.html
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| {{- end -}} | ||
|
|
||
| {{- $sizes := slice 256 196 192 180 167 160 152 120 76 -}} |
There was a problem hiding this comment.
We can render Apple icons at whatever sizes we like. These seem commonly used.
There was a problem hiding this comment.
Seems like a good approach
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
assets/images/kubernetes.png
Outdated
There was a problem hiding this comment.
It seems that relocating and renaming this asset has unintentionally caused the logo to disappear from the navbar on small screens. This might be due to the CSS class (code reference).
// Browser Console Error
GET https://deploy-preview-46325--kubernetes-io-main-staging.netlify.app/images/favicon.png 404 (Not Found)
There was a problem hiding this comment.
Good spot; I have a fix!
sftim
force-pushed
the
20240511_favicon_hugo_pipes
branch
from
9e271ed
to
b1669ed
Compare
Manage favicons for the site using Hugo Pipes to render the sizes we want.
sftim
force-pushed
the
20240511_favicon_hugo_pipes
branch
from
b1669ed
to
6357c3c
Compare
There was a problem hiding this comment.
The changes in the build preview appear good to me.
Preview Site
/lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: dc3a1acb52c442c22017141da1870c32725fe244
|
|
I also reviewed the changes and they lgtm also! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: salaxander The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Manage favicons for the site using Hugo Pipes to render the sizes we want.
Also, work out the theme color automatically.
Helps with issue #41171
/area web-development