Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bn] Fix task pages about installing kubectl #46346

Merged
merged 1 commit into from May 13, 2024

Conversation

sftim
Copy link
Contributor

@sftim sftim commented May 13, 2024

Three existing pages are broken as the links don't expand the current patch release correctly.
Fix that (use skew shortcode instead of deprecated param shortcode).

To see the problem, search in page for release//bin; there should be a version number between the two / characters.

Current Preview
Linux (broken) Linux (preview)
macOS (broken) macOS (preview)
Windows (broken) Windows (preview)

The pages that this PR updates are stale and need further updates; this is a minimum change to make them useful.

/language bn

Split out of #46324

Co-authored-by: Asem Hamid <155321064+asem-hamid@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added language/bn Issues or PRs related to Bengali language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 13, 2024
Copy link

netlify bot commented May 13, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e12802e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6641d9aedb2d630008b0ea53
😎 Deploy Preview https://deploy-preview-46346--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asem-hamid
Copy link
Contributor

Thank you @sftim

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d61906960316184c8fc820763966507291a9d2dc

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Imtiaz1234, mitul3737

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ddc705 into kubernetes:main May 13, 2024
6 checks passed
@sftim sftim deleted the 20240513_fix_bengali_kubectl branch May 15, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants