Edit Statuses

[Moshe-Rappaport-CA]

Describe your changes

Due to the many types of statuses, we are changing it to have 3 statuses:

• passed
• failed
• action required (skipped)

For the controls (control-summary, resource-associates-controls) and for the rules (resource-associated-rules) there will also be a sub-status as defined below:

Status	Sub Status
passed	w/exceptions, irrelevant, (empty)
failed	(empty)
skipped	integration, configuration, manual review, requires review

• For frameworks summary and result summary, there is only status

Below is the difference between the old and new statuses:

	Old statuses	New statuses	Description
1	passed	passed	Control passed on all resources tested
2	excluded	passed (w/exceptions)	Control passed due to all failed results are in exception
3	irrelevant	passed (irrelevant)	No resources were found to test control against (resources count should be 0)
4	skipped	Action required (integration)	Integration is required to test control (resources count should be 0)
5	failed	failed	Control failed
6	failed	Action required (requiresReview)	Control provides information the user needs to review the result manually
7	failed	Action required (configuration)*	Control doesn’t have any configuration or default values in the control configuration (resources count should be 0)
8	—------	Action required (manualReview)	Control can’t be automated. User needs to check manually

* "Action required (configuration)" Also when the status is “passed”

Control types

• A control that has a control-input should contain the "actionRequired": "configuration" attribute.
• A control is a requires review type if it has the "actionRequired": "equires review" attribute.
• A control is a manual review type if it has the "actionRequired": "manual review" attribute.
  A control that is of the manual-review type, should contain a rule with match, which will return the resources as they are

Screenshots - If Any (Optional)

I ran the following command to view the changes in the CLI printout:
kubescape scan control C-9999,C-0004,C-0052,C-0026,C-0085,C-0042,C-0009
The results of these controls on my cluster should be as follows:
"C-0009", should be passed(w/exceptions)
"C-0004", should be skipped(configuration)
"C-9999", should be skipped(manual review)
"C-0052", should be passed(irrelevant)
"C-0026", should be skipped(requires review)
"C-0085", should be skipped(integration)
"C-0042", should be passed

Summary table

Resource view

Prints only the controls that fail

Control view

Checklist before requesting a review

• My code follows the style guidelines of this project
• I have commented on my code, particularly in hard-to-understand areas
• I have performed a self-review of my code
• If it is a core feature, I have added thorough tests.
• New and existing unit tests pass locally with my changes

Please open the PR against the dev branch (Unless the PR contains only documentation changes)

[github-actions]

Hi! Welcome to Kubescape. Thank you for taking the time and contributing to the open source community

We will try to review as soon as possible!

[dwertent]

Please open against the master branch

[dwertent]

@Moshe-Rappaport-CA Well done :)

[matthyx]

@dwertent do we wait for some workflows to merge this one as well?