Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't add host scanner as excluded ns, use exception instead #1083

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

YiscahLevySilas1
Copy link
Contributor

@YiscahLevySilas1 YiscahLevySilas1 commented Feb 7, 2023

Signed-off-by: YiscahLevySilas1 yiscahls@armosec.io

Overview

Don't exclude "kubescape-host-scanner" namespace. That resulted in cluster-wide resources (like nodes, clusterroles..) being excluded on every scan that uses --enable-host-scan.

Additional Information

We'll be using system exceptions instead.
Important - this PR is blocked by this (PR)[https://github.com/kubescape/regolibrary/pull/301] - adding the exception of host-scanner in regolibrary

Checklist before requesting a review

put an [x] in the box to get it checked

  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • New and existing unit tests pass locally with my changes

-->

Signed-off-by: YiscahLevySilas1 <yiscahls@armosec.io>
@dwertent dwertent marked this pull request as draft February 7, 2023 20:05
@dwertent dwertent marked this pull request as ready for review February 7, 2023 20:15
@dwertent dwertent merged commit e90f089 into kubescape:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants