Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure img cmd #1398

Merged
merged 16 commits into from
Oct 22, 2023
Merged

Restructure img cmd #1398

merged 16 commits into from
Oct 22, 2023

Conversation

Daniel-GrunbergerCA
Copy link
Collaborator

@Daniel-GrunbergerCA Daniel-GrunbergerCA commented Sep 21, 2023

Overview

This PR adds the new patch command (by @anubhav06), together with some changes on it and on the scan image command. These are mainly changes made on this PR, but without changing the commands hierarchy. The decision was to keep the commands as first proposed, for now.

anubhav06 and others added 11 commits August 5, 2023 00:18
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
feat: add kubescape patch command
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
@ghost
Copy link

ghost commented Sep 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Daniel-GrunbergerCA
Copy link
Collaborator Author

Daniel-GrunbergerCA commented Sep 21, 2023

cc @anubhav06 @dwertent

@anubhav06
Copy link
Contributor

anubhav06 commented Sep 21, 2023

There is also PR#1374 which changes the reference from anubhav06/copacetic back to project-copacetic/copacetic, if that is something that needs to be considered right now. Otherwise, if changing the reference back to original repo is not a priority at the moment, then we can ignore that PR for now (until copacetic and kubescape support integration is released).

@github-actions
Copy link

Scan results:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure

Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Scan results:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure

@matthyx
Copy link
Contributor

matthyx commented Oct 9, 2023

@Daniel-GrunbergerCA needs rebase

Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
Daniel Grunberger added 3 commits October 19, 2023 09:35
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
@dwertent dwertent merged commit 72b6412 into master Oct 22, 2023
43 of 45 checks passed
matthyx pushed a commit to matthyx/kubescape that referenced this pull request Oct 23, 2023
* feat: add kubescape patch command

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>

* update patch command output format

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>

* fix patch command logic

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>

* update docs & minor changes

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>

* restructure cmd

Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>

* fix tests

Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>

* readme

Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>

* fix version code

Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>

* go mod

Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>

---------

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Signed-off-by: Daniel Grunberger <danielgrunberger@armosec.io>
Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com>
Co-authored-by: Daniel Grunberger <danielgrunberger@armosec.io>
@dwertent dwertent deleted the restructure-img-cmd branch October 26, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants