Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support backend access key #1404

Merged
merged 36 commits into from
Oct 22, 2023
Merged

Support backend access key #1404

merged 36 commits into from
Oct 22, 2023

Conversation

rcohencyberarmor
Copy link
Contributor

@rcohencyberarmor rcohencyberarmor commented Oct 1, 2023 •
edited by amirmalka

In this PR we will add access key to each client request that want to submit the kubescape result to the backend.

  1. Helm - the access key will be provide from the Helm CLI with the an argument and will be saved in the k8s cluster as a secret, therefore in the PRs belows this is what we did.
  2. Kubescape CLI - the access key will be under the $HOME/.kubescape/config.json file. but in the first time the access token will be generated when the user will use the the flag submit by the backend and will be provided by specific backend REST API call (Not part of this PR)

rcohencyberarmor added 18 commits September 5, 2023 12:08
adding operator CLI to kubescape
6ae8632 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
support http requet for trigger in cluster operator
9548004 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
create interface for create request payload
799cb56 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
logs + go mod update
b721ae7 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
docs
48b3e13 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
add relevant system tests
2ad0cc2 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
linter corrections
79c18d0 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Merge branch 'master' of github.com:kubescape/kubescape into support-…
17434b8 
…control-cluster-from-CLI
code review corrections
5cb8e6d 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
remove non relevant system tests - after code review corrections
0692d7c 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
PR corrections
c48418b 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
PR corrections
578171d 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
change log
10bdb4b 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
remove from examples
4a95fda 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
change log
093910b 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
test correction
e8f0529 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
Merge branch 'master' of github.com:kubescape/kubescape into support-…
0f2d585 
…control-cluster-from-CLI
add access token while connect to the backend
78d3602 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
@ghost
Copy link

ghost commented Oct 1, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Scan results:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure

@craigbox
Copy link
Contributor

craigbox commented Oct 1, 2023

Can you add a brief description of the PR please?

unitets
e3bf82e 
Signed-off-by: rcohencyberarmor <rcohen@armosec.io>
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Scan results:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure

@amirmalka
use backend package for loading secret
d5da27d 
Signed-off-by: Amir Malka <amirm@armosec.io>
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Scan results:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure

@amirmalka
Merge branch 'master' of github.com:armosec/kubescape into support-ba…
69d973b 
…ckend-access-token

Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
update backend pkg
fe26f21 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
update backend pkg
faf1da5 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
Merge branch 'master' of github.com:armosec/kubescape into support-ba…
b9e0025 
…ckend-access-token

Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
update backend pkg
926a83b 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
remove irrelevant code
b78490e 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
update
e0fa5f3 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka amirmalka changed the title Support backend access token Support backend access key Oct 19, 2023
@amirmalka
update backend pkg
c081376 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
update backend pkg
9299536 
Signed-off-by: Amir Malka <amirm@armosec.io>
dwertent
dwertent previously approved these changes Oct 19, 2023
View reviewed changes
@amirmalka
fix
f66c074 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
Merge branch 'master' of github.com:armosec/kubescape into support-ba…
7cd3cf7 
…ckend-access-token
@amirmalka
unified config fix
ea62af4 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
fix
f2d8b6e 
Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka
do not fail on config init - for BC
2169eaa 
Signed-off-by: Amir Malka <amirm@armosec.io>
dwertent
dwertent previously approved these changes Oct 22, 2023
View reviewed changes
@amirmalka
Merge branch 'master' of github.com:armosec/kubescape into support-ba…
610bbfc 
…ckend-access-token

Signed-off-by: Amir Malka <amirm@armosec.io>
@amirmalka amirmalka merged commit 052c042 into master Oct 22, 2023
10 of 11 checks passed
@p-linnane p-linnane mentioned this pull request Oct 22, 2023
Merged
matthyx pushed a commit to matthyx/kubescape that referenced this pull request Oct 23, 2023
@rcohencyberarmor @matthyx
Support backend access key (kubescape#1404)
2749c6d 
Support backend access key

Signed-off-by: Amir Malka <amirm@armosec.io>
@dwertent dwertent deleted the support-backend-access-token branch October 26, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirmalka amirmalka amirmalka left review comments

@dwertent dwertent dwertent approved these changes

Assignees

@amirmalka amirmalka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rcohencyberarmor @craigbox @amirmalka @dwertent