fix install.sh when sudo is required to delete /usr/local/bin/kubescape #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirmalka
previously approved these changes
Nov 22, 2023
|
@matthyx just confirming - did we test the fix on different OS? |
MacOS (10.13 and 10.14) and Linux - I don't have a Windows machine to test on MinGW. |
|
There is another issue (saw it on Windows) the cleanup of kubescape deletes the location where the file is downloaded (probably a path detection issue). |
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Daniel-GrunbergerCA
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.