Add github action actor check for binary-build #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mmmmmmorty <mmmmmmorty@outlook.com>
matthyx
approved these changes
Nov 28, 2023
|
thanks @MMMMMMorty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added a check before running the binary-build job to ensure that the owner of the repository is kubescape.
Fixes: #1482
Additional Information
I tested #1490, it seems it doesn't work properly. Since for the repository_owner, it is the same for internal or external PR, which is kubescape, so it cannot skip the job. More than that, the check is added to pr-scanner instead of binary-build.
Here, I check the actor of the action instead of repository_owner, for me (external PR), it will be MMMMMMorty, instead of kubescape.
I tested this on my other PR https://github.com/kubescape/kubescape/actions/runs/7019483545, it skips the binary-build.