Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for exception rules #1580 #1643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support for exception rules #1580 #1643

wants to merge 1 commit into from

Conversation

Sriramkashyapks
Copy link

Overview

@Sriramkashyapks
support for exception rules kubescape#1580
f99cb0d 
Signed-off-by: Sriram Kashyap <kssriramkashyap002@gmail.com>
@Sriramkashyapks
Copy link
Author

Hey there if the above code Ive pushed is correct please merge it

@matthyx
Copy link
Contributor

matthyx commented Mar 27, 2024

@Sriramkashyapks I don't see any code change in your commit... also please don't forget test coverage as well :)

@nunidoron
Copy link

As @matthyx said, please dont forget to cover your tests :)

nunidoron
nunidoron reviewed May 16, 2024
View reviewed changes
examples/exceptions/exclude-allowed-hostPath-control.json
"excludedNamespaces": ["..."],
"failThreshold": "...",
"complianceThreshold": "...",
"format": "...",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are sure that you need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunidoron nunidoron nunidoron left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sriramkashyapks @matthyx @nunidoron