chore(core/pkg/resultshandling): add control id to pdf output #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new column in the PDF output to reference each control that has been executed as control ID. Signed-off-by: Massimiliano Giovagnoli <me@maxgio.it>
|
Hello, are there any constraints external to the printer's technical ones to limit the control description width to 53 characters ( |
Hi @maxgio92 nice to meet you! |
I guess it was to not get out from the pdf column. |
alegrey91
approved these changes
Apr 11, 2024
|
Hey @alegrey91, I tested it and it seems that with this new column split 70 characters are supported |
matthyx
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new column in the PDF output to reference each control that has been executed as control ID.
Additional Information
The PDF report is useful, especially for assessment overviews.
As of now a reference to each control, independently of the framework, is missing and only a description.
The description of the control is not enough to reference the documentation of the control, remediation.
Furthermore, this PR increments the control description volume width to 73 characters, from 53.
How to Test
Examples/Screenshots
Related issues/PRs:
#1661