Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump sigs.k8s.io/controller-runtime to v0.14.4 #5507

Merged
merged 2 commits into from Feb 8, 2023
Merged

Bump sigs.k8s.io/controller-runtime to v0.14.4 #5507

merged 2 commits into from Feb 8, 2023

Conversation

wansir
Copy link
Member

@wansir wansir commented Feb 7, 2023

What type of PR is this?

/kind cleanup
/kind regression

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related to:

kubernetes-sigs/controller-runtime#1907
kubernetes-sigs/controller-runtime#1792

Does this PR introduced a user-facing change?

None

@ks-ci-bot ks-ci-bot added release-note-none kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 7, 2023
@ks-ci-bot
Copy link
Collaborator

@wansir: The label(s) kind/regression cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup
/kind regression

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related to:

kubernetes-sigs/controller-runtime#1907
kubernetes-sigs/controller-runtime#1792

Does this PR introduced a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wansir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2023
@wansir wansir requested review from hongzhouzi and iawia002 and removed request for hongzhouzi February 7, 2023 03:44
@hongzhouzi
Copy link
Member

/retest

2 similar comments
@wansir
Copy link
Member Author

wansir commented Feb 7, 2023

/retest

@wansir
Copy link
Member Author

wansir commented Feb 7, 2023

/retest

@wansir wansir force-pushed the master branch 3 times, most recently from 442277a to 5639685 Compare February 8, 2023 01:46
@iawia002
Copy link
Member

iawia002 commented Feb 8, 2023

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: bcc4ac2e3da8c1ee0d408f41b3b308b7b26df72b

@ks-ci-bot ks-ci-bot merged commit 1c49fcd into kubesphere:master Feb 8, 2023
sologgfun pushed a commit to sologgfun/kubesphere that referenced this pull request Apr 24, 2023
@wansir @sologgfun
Bump sigs.k8s.io/controller-runtime to v0.14.4 (kubesphere#5507)
001de94 
* Bump sigs.k8s.io/controller-runtime to v0.14.4

* Update gofmt
wanjunlei pushed a commit to wanjunlei/kubesphere that referenced this pull request Aug 11, 2023
@wansir @wanjunlei
Bump sigs.k8s.io/controller-runtime to v0.14.4 (kubesphere#5507)
53c3299 
* Bump sigs.k8s.io/controller-runtime to v0.14.4

* Update gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iawia002 iawia002 Awaiting requested review from iawia002

@hongzhouzi hongzhouzi Awaiting requested review from hongzhouzi

Assignees

@iawia002 iawia002

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wansir @ks-ci-bot @hongzhouzi @iawia002