Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cue structure implemented #6441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kartikaysaxena
Copy link

Fixes #6436
Implemented cue structure in the docs as per the issue.

@kartikaysaxena kartikaysaxena changed the title cue structure implemented Fix: cue structure implemented Jan 14, 2024
@kartikaysaxena
Copy link
Author

@anoop2811 please take a look.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86dc53a) 33.12% compared to head (be7a4fc) 61.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6441       +/-   ##
===========================================
+ Coverage   33.12%   61.51%   +28.39%     
===========================================
  Files         141      178       +37     
  Lines       16402    23672     +7270     
===========================================
+ Hits         5433    14562     +9129     
+ Misses      10285     7679     -2606     
- Partials      684     1431      +747     
Flag Coverage Δ
core-unittests 55.24% <ø> (?)
e2etests 33.19% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
- "spec.template.spec.containers[0].image"
cue:
template: |
apiVersion: "apps/v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be wrapped in output.

}
}
}
parameters: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parameters is not an array but a map.

Copy link
Contributor

@anoop2811 anoop2811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please give more info on how this was tested?

cue:
template: |
apiVersion: "apps/v1"
kind: "Deployment"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take care of indenting and trailing whitespaces?

cue:
template: |
apiVersion: "apps/v1"
kind: "Deployment"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take care of indenting and trailing whitespaces?

Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@wonderflow
Copy link
Collaborator

you can test and validate the result by vela dry-run

@anoop2811
Copy link
Contributor

Hi @kartikaysaxena , could you please add how you tested these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix documentation where schematic for component definition refers to kube
4 participants