Restart required correctly propagate #11904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the `DeepCopy` from updateStatus allow us to detect changes to the Status inside the "sync" and acaccurately represent changes. Signed-off-by: Luboslav Pivarc <lpivarc@redhat.com>
VM CRD has a status subresource enabled. This means that "Update" ignores changes to the status stanza. Also propagate status changes from "hotplug sync" by returning the cloned vm. Signed-off-by: Luboslav Pivarc <lpivarc@redhat.com>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Otherwise if a VM gets created with RunStrategy == Halted|Manual and then switched to RerunOnFailure the VM will not start. Signed-off-by: Antonio Cardace <acardace@redhat.com>
acardace
force-pushed
the
restart-required-xpivarc
branch
from
b13b210
to
8b619e0
Compare
kubevirt-bot
added
dco-signoff: yes
acardace
requested review from
fossedihelm and
jean-edouard
and removed request for
lyarwood and
EdDev
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
/cc |
alicefr
reviewed
May 15, 2024
|
|
||
| // only add the condition if the VM has been started at least once | ||
| if vmi != nil { | ||
| vm.Status.Conditions = append(vm.Status.Conditions, virtv1.VirtualMachineCondition{ |
There was a problem hiding this comment.
can you please use the conditionmanager and the UpdateCondition method
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes cases where RestartRequired condition is not propagated to Kubernetes API. The cause is
Updatecall that should not be called when only.Statusis changed (note if a change was made the condition will be missing). Also ensure that we detect a.Statuschange in theupdateStatus.Fixes #
Special notes for your reviewer
Release note
Based on #11726 and #11836
This PR only adds 8b619e0 on top of #11836 to fix an API regression.