-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create kubevirt_vmi_info metric #11906
Create kubevirt_vmi_info metric #11906
Conversation
e3933c7
to
fff7239
Compare
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
fff7239
to
29ba5b3
Compare
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3, sradco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Required labels detected, running phase 2 presubmits: |
/retest-required |
@machadovilaca: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does
Before this PR:
kubevirt_vmi_phase_count has OS label but doesn't identify VMI, so we cannot use this information to filter VMStorageClassWarning only for VMI with Windows OS reported by the guest.
After this PR:
We create a kubevirt_vmi_info metric, similar to kube_pod_info, that contains detailed information about the workload, including the name and namespace.
We also create a recording rule for kubevirt_vmi_phase_count, that aggregates the new kubevirt_vmi_info by node, phase, os, workload, flavor, instance_type and preference.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note
Jira Ticket