Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use precompiled protoc #5959

Merged
merged 1 commit into from Jul 1, 2021
Merged

Use precompiled protoc #5959

merged 1 commit into from Jul 1, 2021

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Jul 1, 2021

What this PR does / why we need it:

Pull in protoc the right way, so that we can use a released binary
instead of compiling protoc ourselves on every branch switch.

This saves quite some compile time during local development.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

For more context see bazelbuild/rules_scala#1142 and bazelbuild/rules_proto#36

Release note:

NONE

Pull in protoc the right way, so that we can use a released binary
instead of compiling protoc ourselves on every branch switch.

Signed-off-by: Roman Mohr <rmohr@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Jul 1, 2021
@rmohr
Copy link
Member Author

rmohr commented Jul 1, 2021

/cc @kwiesmueller FYI

@kubevirt-bot
Copy link
Contributor

@rmohr: GitHub didn't allow me to request PR reviews from the following users: FYI.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kwiesmueller FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rmohr
Copy link
Member Author

rmohr commented Jul 1, 2021

/cc @dhiller

@kubevirt-bot kubevirt-bot requested a review from dhiller July 1, 2021 08:29
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@kubevirt-bot kubevirt-bot merged commit 1c83072 into kubevirt:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants