Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint v7 #190

Merged
merged 10 commits into from Jun 25, 2020
Merged

Support ESLint v7 #190

merged 10 commits into from Jun 25, 2020

Conversation

koba04
Copy link
Collaborator

@koba04 koba04 commented May 12, 2020

ESLint v7 has been released so we'd like to support ESLint v7.
https://eslint.org/blog/2020/05/eslint-v7.0.0-released

THIS PR IS A BREAKING CHANGE because this drops to support ESLint v6.

Tasks

BREAKING CHANGE: Support minimum ESLint version is v7.
BREAKING CHANGE: Enable new rules in @typescript-eslint/recommended

- @typescript-eslint/no-extra-non-null-assertion
- @typescript-eslint/no-extra-semi
- @typescript-eslint/no-non-null-asserted-optional-chain
- ⚠️ @typescript-eslint/prefer-as-const
@koba04 koba04 marked this pull request as ready for review June 15, 2020 15:06
@koba04 koba04 requested a review from a team as a code owner June 15, 2020 15:06
@koba04 koba04 requested review from MRTAFU and removed request for a team June 15, 2020 15:06
@koba04
Copy link
Collaborator Author

koba04 commented Jun 15, 2020

You would see the warning while installing this config.

warning " > eslint-plugin-jsx-a11y@6.2.3" has incorrect peer dependency "eslint@^3 || ^4 || ^5 || ^6".

But eslint-plugin-jsx-a11y has supported ESLint v7 at the latest commit, which hasn't been published yet, and the commit has no changes for their source code, so we can update ESLint to v7 safely even though the waring.

jsx-eslint/eslint-plugin-jsx-a11y@b273fe5

Copy link
Contributor

@MRTAFU MRTAFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@koba04 koba04 merged commit ba8ea8e into kufu:master Jun 25, 2020
@koba04 koba04 deleted the eslint-v7 branch June 25, 2020 10:38
@koba04
Copy link
Collaborator Author

koba04 commented Jun 25, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants