chore: eslint-plugin-smarthr を peerDependencies から外す #822
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-sasaki-0529
requested review from
AtsushiM and
yamish123
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
にて議論しましたが、やはり
eslint-config-smarthrにとっては常に最新のeslint-plugin-smarthrを使用して欲しいという意図があると思うので、peerDependenciesから外してdependenciesのみにします。これによって、pnpm v9 であっても、最新の
eslint-config-smarthrをインストールした場合はそこで定義されている最新のeslint-plugin-smarthrが使用されるようになります。(pnpm v8 や yarn の場合は、
peerDependenciesとdependencies両方定義してる場合に後者を優先してくれてたみたい)