fix: calculated cache key based on supportsStaticESM

kulshekhar · Jan 19, 2024 · 69325d6 · 69325d6
1 parent e7be4bf
commit 69325d6
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/src/legacy/ts-jest-transformer.spec.ts b/src/legacy/ts-jest-transformer.spec.ts
@@ -189,6 +189,10 @@ describe('TsJestTransformer', () => {
           ...input.transformOptions,
           config: { ...input.transformOptions.config, instrument: true },
         }),
+        tr.getCacheKey(input.fileContent, input.fileName, {
+          ...input.transformOptions,
+          supportsStaticESM: true,
+        }),
         tr.getCacheKey(input.fileContent, input.fileName, {
           ...input.transformOptions,
           config: { ...input.transformOptions.config, rootDir: '/bar' },
@@ -242,6 +246,27 @@ describe('TsJestTransformer', () => {
       expect(cacheKey1).not.toEqual(cacheKey2)
     })
 
+    test('should be different between supportsStaticESM true and supportsStaticESM false', () => {
+      jest.spyOn(TsJestCompiler.prototype, 'getResolvedModules').mockReturnValueOnce([])
+
+      const cacheKey1 = tr.getCacheKey(input.fileContent, input.fileName, {
+        ...transformOptionsWithCache,
+        supportsStaticESM: true,
+      })
+
+      jest.spyOn(TsJestCompiler.prototype, 'getResolvedModules').mockReturnValueOnce([])
+      const tr1 = new TsJestTransformer()
+      const cacheKey2 = tr1.getCacheKey(input.fileContent, input.fileName, transformOptionsWithCache)
+
+      expect(TsJestCompiler.prototype.getResolvedModules).toHaveBeenCalledTimes(1)
+      expect(TsJestCompiler.prototype.getResolvedModules).toHaveBeenCalledWith(
+        input.fileContent,
+        input.fileName,
+        new Map(),
+      )
+      expect(cacheKey1).not.toEqual(cacheKey2)
+    })
+
     test('should be different with different file content for the same file', () => {
       jest.spyOn(TsJestCompiler.prototype, 'getResolvedModules').mockReturnValueOnce([])
 

diff --git a/src/legacy/ts-jest-transformer.ts b/src/legacy/ts-jest-transformer.ts
@@ -308,14 +308,16 @@ export class TsJestTransformer implements SyncTransformer {
     this._logger.debug({ fileName: filePath, transformOptions }, 'computing cache key for', filePath)
 
     // we do not instrument, ensure it is false all the time
-    const { instrument = false } = transformOptions
+    const { supportsStaticESM, instrument = false } = transformOptions
     const constructingCacheKeyElements = [
       this._transformCfgStr,
       CACHE_KEY_EL_SEPARATOR,
       configs.rootDir,
       CACHE_KEY_EL_SEPARATOR,
       `instrument:${instrument ? 'on' : 'off'}`,
       CACHE_KEY_EL_SEPARATOR,
+      `supportsStaticESM:${supportsStaticESM ? 'on' : 'off'}`,
+      CACHE_KEY_EL_SEPARATOR,
       fileContent,
       CACHE_KEY_EL_SEPARATOR,
       filePath,