Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle tsBuildInfoFile option #1096

Merged
merged 1 commit into from Sep 1, 2019
Merged

fix: handle tsBuildInfoFile option #1096

merged 1 commit into from Sep 1, 2019

Conversation

haines
Copy link
Contributor

@haines haines commented May 10, 2019

Fixes #1095

@haines haines marked this pull request as ready for review May 10, 2019 14:46
@haines
Copy link
Contributor Author

haines commented May 10, 2019

Confirmed that this fixes the minimal repro: https://travis-ci.org/haines/ts-jest-tsbuildinfo-bug-repro/builds/530788880

@coveralls
Copy link

coveralls commented May 10, 2019

Pull Request Test Coverage Report for Build 3237

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.033%

Totals Coverage Status
Change from base Build 3236: 0.0%
Covered Lines: 1068
Relevant Lines: 1128

💛 - Coveralls

ahnpnl
ahnpnl previously approved these changes May 11, 2019
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haines
Copy link
Contributor Author

haines commented May 30, 2019

Hi, is there anything else I can do to help get this merged? We're currently unable to use ts-jest and having to compile and then run Jest against our compiled .js, which is a bit painful.

@haines
Copy link
Contributor Author

haines commented Jul 19, 2019

I've resolved conflicts, hope we can get this merged soon?

@lummish
Copy link

lummish commented Aug 27, 2019

What's the status here? I'm still running into this issue.

ahnpnl
ahnpnl previously approved these changes Sep 1, 2019
@ahnpnl
Copy link
Collaborator

ahnpnl commented Sep 1, 2019

Please resolve conflicts again 😀

@haines
Copy link
Contributor Author

haines commented Sep 1, 2019

@ahnpnl done!

@ahnpnl
Copy link
Collaborator

ahnpnl commented Sep 1, 2019

@kulshekhar @GeeWee I think this can be merged

@kulshekhar kulshekhar merged commit 9ff8450 into kulshekhar:master Sep 1, 2019
@kulshekhar
Copy link
Owner

@haines thanks for the PR!
@ahnpnl thanks for reviewing it!

@haines haines deleted the tsbuildinfo branch November 12, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript 3.4's tsBuildInfoFile option breaks ts-jest
5 participants