Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve diagnostics check #1464

Merged
merged 5 commits into from Mar 30, 2020
Merged

chore: improve diagnostics check #1464

merged 5 commits into from Mar 30, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Mar 29, 2020 •
edited

@ahnpnl ahnpnl requested a review from kulshekhar March 29, 2020 09:33
@coveralls
Copy link

coveralls commented Mar 29, 2020 •
edited

Pull Request Test Coverage Report for Build 4232

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 93.016%
Totals Coverage Status
Change from base Build 4230: 0.3%
Covered Lines: 1130
Relevant Lines: 1167
💛 - Coveralls

@ahnpnl ahnpnl merged commit 8b5325e into kulshekhar:master Mar 30, 2020
@ahnpnl ahnpnl deleted the improve-diagnostics-check branch March 30, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahnpnl @coveralls @kulshekhar