Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): make sure ts files in node_modules always transform properly #1525

Closed
wants to merge 2 commits into from

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 13, 2020

Summary

In #1385 we had this fix. Then in 25.3.0 and 25.3.1 I removed it because the new codes for compiler worked for the case of monorepo. However, the solution in #1385 actually can cover all the cases. So this PR is to bring that fix back.

closes #1523

Test plan

Added the repo of issue #1523 to our e2e tests.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4412

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 93.067%

Totals Coverage Status
Change from base Build 4411: 0.1%
Covered Lines: 1164
Relevant Lines: 1199

💛 - Coveralls

@ahnpnl ahnpnl closed this Apr 13, 2020
@ahnpnl ahnpnl deleted the fix-1523 branch April 13, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type script reference path is not getting resolved in jest
2 participants